[Merged by Bors] - chore(Data/Finset): golf entire diag_union_offDiag, erase_right_comm, univ_filter_mem_range and powersetCard_map using grind#28681
Closed
euprunin wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
Contributor
euprunin
commented
Aug 20, 2025
euprunin
commented
PR summary 59c724d051Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
euprunin
changed the title
diag_union_offDiag, erase_right_comm, univ_filter_mem_range and powersetCard_map using grinddiag_union_offDiag, erase_right_comm, univ_filter_mem_range and powersetCard_map using grind
Contributor
|
Can you say something about the performance of this change - and bundle with other Data PR, please? Thanks! |
grunweg
added
the
awaiting-author
…niv_filter_mem_range` and `powersetCard_map` using `grind`
euprunin
force-pushed
the
golf-cclxxxiii
branch
from
ec32a50 to
c11c970
Compare
|
!bench |
Collaborator
|
Here are the benchmark results for commit c11c970. |
|
Contributor
Author
|
@grunweg Thanks for reviewing! The benchmarking results suggest that performance is unchanged. |
euprunin
removed
the
awaiting-author
Contributor
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
ghost
added
the
maintainer-merge
Contributor
|
Thanks! |
ghost
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
…mm`, `univ_filter_mem_range` and `powersetCard_map` using `grind` (#28681)
Contributor
|
Build failed (retrying...): |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
…mm`, `univ_filter_mem_range` and `powersetCard_map` using `grind` (#28681)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
diag_union_offDiag, erase_right_comm, univ_filter_mem_range and powersetCard_map using grinddiag_union_offDiag, erase_right_comm, univ_filter_mem_range and powersetCard_map using grind
yuanyi-350
pushed a commit
to yuanyi-350/yuanyi_mathlib4
that referenced
this pull request
Sep 10, 2025
…mm`, `univ_filter_mem_range` and `powersetCard_map` using `grind` (leanprover-community#28681)
robertmaxton42
pushed a commit
to robertmaxton42/mathlib4
that referenced
this pull request
Sep 11, 2025
…mm`, `univ_filter_mem_range` and `powersetCard_map` using `grind` (leanprover-community#28681)
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Oct 2, 2025
…mm`, `univ_filter_mem_range` and `powersetCard_map` using `grind` (leanprover-community#28681)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.